Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Demo Model Page #903

Closed
wants to merge 7 commits into from

Conversation

itsdheerajdp
Copy link
Collaborator

@itsdheerajdp itsdheerajdp commented Mar 5, 2024

Summary:

Description for the changelog:
Embedded the i18n with the Demo Model Page For better User Experience.

Other info:

Thanks for submitting a pull request!
Please make sure you follow our code_of_conduct.md and our contributing guidelines contributing.md

@itsdheerajdp itsdheerajdp requested a review from jgadsden March 5, 2024 15:31
Copy link
Collaborator

@jgadsden jgadsden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is a set of failing unit tests at tests/unit/views/demo/selectDemoModel.spec.js, if we could fix these up

@itsdheerajdp
Copy link
Collaborator Author

there is a set of failing unit tests at tests/unit/views/demo/selectDemoModel.spec.js, if we could fix these up

I'll fix this

@itsdheerajdp
Copy link
Collaborator Author

@jgadsden can i have your assistance in how to carry forward with the changes required in the tests/unit/views/demo/selectDemoModel.spec.js.

@itsdheerajdp
Copy link
Collaborator Author

@jgadsden i was trying to update the unit test cases but not getting the exact solution. It'll be great if i get your assistance in this.

@itsdheerajdp itsdheerajdp deleted the Fixes/DemoModelPage branch March 12, 2024 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants